fix: VS Code sessions causing false active dots - #78
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VS Code Claude Code sessions (
entrypoint: "claude-vscode") were causing false purple active dots on unrelated terminal sessions.Root cause
Detection flow in
detectActiveSessions()(PR #67):~/.claude/sessions/<PID>.json→ PID alive ✓ (VS Code is running)sessionIdagainsthistory.jsonl→ no match (VS Code sessions are not written to history.jsonl)cwdCandidates.length === 1→ mark that closed session as active → wrong purple dotThe user observed:
codex-ffproject showed purple dot, but no terminal had that session openFix
Skip non-CLI sessions at step 1:
Known
entrypointvalues (from~/.claude/sessions/<PID>.json):entrypointcliclaude-vscodeclaude-desktopundefinedNo side effects
ps aux, not sessions/ filesneedsCrossRef[VSCODE]badge and VS Code window activation, we'll handle non-cli entrypoints in a separate code path instead of letting them fall into the terminal detection flowTest plan
🤖 Generated with Claude Code
🤖 On behalf of @grimmerk — generated with Claude Code