Skip to content

fix(README): Code Examples #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
babblebey wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(README): Code Examples #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f57f6
fix: typo in `Write credentials into a `.env` file.` section of README
babblebey Apr 26, 2024
0f65b11
fix: typo in `Register an app on an organization` README section
babblebey Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const appCredentials = await registerGitHubApp({
issues: "write",
},
// List of events for new installations
evedefault_events: ["issues"],
default_events: ["issues"],
});

// convert private key to pkcs8 format (recommended for better cross plattform support)
Expand Down Expand Up @@ -72,7 +72,7 @@ const appCredentials = await registerGitHubApp({
issues: "write",
},
// List of events for new installations
evedefault_events: ["issues"],
default_events: ["issues"],

@babblebey babblebey Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gr2m,

This entire property present in the configuration is leading to an error

image

I since discovered that inorder for us to listen for a certain event, then we've gotta also configure the "hook_attributes" and that isn't present in the code example..

So, should this be added or should we remove the default_events entirely!???

@gr2m gr2m Apr 29, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I think we should define hook_attributes as well

});
```

Expand Down