Skip to content

Remove 'as GPUFeatureName' casts that are no longer needed. - #4710

Merged
kainino0x merged 2 commits into
gpuweb:mainfrom
Kangz:tca
Sep 21, 2026
Merged

kainino0x merged 2 commits into
gpuweb:mainfrom
Kangz:tca

Conversation

@Kangz

@Kangz Kangz commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Since the features where added to webgpu-types

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@Kangz
Kangz requested a review from kainino0x September 21, 2026 08:43
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Results for build job (at 389eb65):

 Test case/subcase counts did not change.

Since the features where added to webgpu-types
@kainino0x
kainino0x enabled auto-merge (squash) September 21, 2026 18:34
@kainino0x
kainino0x disabled auto-merge September 21, 2026 18:34
@kainino0x
kainino0x enabled auto-merge (squash) September 21, 2026 18:34
@kainino0x
kainino0x merged commit 297e3f3 into gpuweb:main Sep 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants