Skip to content

Add chained swizzle tests - #4699

Merged
sudonatalie merged 1 commit into
gpuweb:mainfrom
sudonatalie:chained-swizzle-single
Sep 9, 2026
Merged

sudonatalie merged 1 commit into
gpuweb:mainfrom
sudonatalie:chained-swizzle-single

Conversation

@sudonatalie

Copy link
Copy Markdown
Contributor

Add some additional tests of chained swizzles ending in a single element swizzle. These are regression tests for the bug caught in: https://crbug.com/553777974

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

Add some additional tests of chained swizzles ending in a single element
swizzle. These are regression tests for the bug caught in:
https://crbug.com/553777974
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Results for build job (at af730be):

-webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6600 subcases (~110/case)
-webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2640 subcases (~110/case)
+webgpu:shader,validation,expression,access,vector:concrete:* - 60 cases, 6660 subcases (~111/case)
+webgpu:shader,validation,expression,access,vector:abstract:* - 24 cases, 2664 subcases (~111/case)
+webgpu:shader,validation,expression,access,vector:chained_swizzle:* - 6 cases, 6 subcases (~1/case)
-TOTAL: 285364 cases, 2347068 subcases
+TOTAL: 285370 cases, 2347158 subcases

@sudonatalie
sudonatalie merged commit e0540c5 into gpuweb:main Sep 9, 2026
1 check passed
@sudonatalie
sudonatalie deleted the chained-swizzle-single branch September 9, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants