Repository navigation
Conversation
gpu
left a comment
gpu
left a comment
There was a problem hiding this comment.
The native libraries should not be part of the repo. The repo is intended for the source code. They might be part of the release, either as the ZIP on jocl.org, or possibly here on GitHub
gpu
left a comment
gpu
left a comment
There was a problem hiding this comment.
That's a bit difficult: I don't know which os.arch strings are out there. Of course, you know better which ones appear on android. But from what I can see, the original case of
if (osArch.startsWith("arm"))
is no longer covered now. Maybe it should be added again, to cover the case of "some" ARM architecture that is neither arm5tel nor armv7hl ....
| @@ -51,17 +51,11 @@ if(ANDROID) | |||
| # mips, mips64 | |||
| # } | |||
| # TODO: Support more than just "arm" in LibUtils | |||
There was a problem hiding this comment.
This TODO only refers to Android, right?
gpu
left a comment
gpu
left a comment
There was a problem hiding this comment.
The "empty" changes in the .java files (except for LibUtils, of course) are probably due to different line endings, right?
(It's a pity that GitHub does not seem to be able to show these differences in any way)
If so, it would be nice if the "not-changed" files could be omitted
|
In doubt, I'd try to allocate some time (possibly next week) to apply the changes to the code and makefile locally, and create a ZIP from the resulting JAR, together with the native libraries, so that you can try out whether the result works on your system. |
|
Oh I'd like to be the first person to try tomato. Ha Ha. |
|
Well, it will still contain your binaries and your changes, so it's your tomato ;-) I'd just like to avoid having the natives in the repo, and wanted to cover the |
|
I assume that JOCL essentially "works" on Android, as of #44 , and going to close this one. |
No description provided.