Unify constants #86

Activity

1. bolding commented on Apr 29, 2026

   

   bolding

   on Apr 29, 2026

   Collaborator

   More actions

   You are right - but it seems nobody really has resources to maintain GOTM.

   At least I'm behind with two things I've already promised.
2. knutaros commented on May 6, 2026

   

   knutaros

   on May 6, 2026 via email

   Contributor

   More actions

   hans asked me to resolve the inconsistencies. but I am now sure what is more important: bwd compatibility or minor(?) inconsistencies in air-sea flux calculations...

   …

   On 4/28/26 12:18, Bruno Deremble wrote: *bderembl* created an issue (gotm-model/code#86) <#86> This is a minor issue but several constants are re-defined in airsea_variable: |REALTYPE, public, parameter :: cpw=3985. REALTYPE, public, parameter :: emiss=0.97 REALTYPE, public, parameter :: bolz=5.670374419e-8 REALTYPE, public, parameter :: kelvin=273.15 REALTYPE, public, parameter :: const06=0.62198 REALTYPE, public, parameter :: rgas = 287.1 ! REALTYPE, public, parameter :: g = 9.81 ! [m/s2] REALTYPE, public, parameter :: rho_0 = 1025. ! [kg/m3] REALTYPE, public, parameter :: kappa = 0.41 ! von Karman | I see at least cpw, g, rho_0, kappa — Reply to this email directly, view it on GitHub <#86>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2RV6SYTEMVD3C7LAUOR534YCAPPAVCNFSM6AAAAACYJEU7LSVHI2DSMVQWIX3LMV43ASLTON2WKOZUGM2DEMZSGM4DSNY>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
3. bolding commented on May 7, 2026

   

   bolding

   on May 7, 2026

   Collaborator

   More actions

   I think the issue is that some constants are defined twice - as they are used in different contexts?
4. knutaros commented on May 7, 2026

   

   knutaros

   on May 7, 2026 via email

   Contributor

   More actions

   exactly, and they are defined with different (default) values.

   …

   On 5/7/26 08:33, Karsten Bolding wrote: *bolding* left a comment (gotm-model/code#86) <#86 (comment)> I think the issue is that some constants are defined twice - as they are used in different contexts? — Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2RV6XAG33O7RKOS2443J34ZQUZ5AVCNFSM6AAAAACYJEU7LSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOJUGQZDMOJTGA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>