Feature suggestion: auto content-type on blob creation #47

Activity

1. chingor13 commented on Dec 7, 2018

   

   chingor13

   on Dec 7, 2018

   Contributor

   More actions

   I assume you mean that we would try to detect the file type and automatically set the Content-type metadata for the blob.

   On the client side, we don't do this for developers because there are several different ways to accomplish in Java (extension, magic bytes) this with pros/cons for each method. We don't want to dictate how or whether to automatically detect the mime type so it's left to developers to do. You can do a quick Google search for "java file mime type" for several methods of detecting the mime type.

   If you'd like to file a feature request against the actual backend API, you can file an issue against the service: https://issuetracker.google.com/issues/new?component=187243&template=0
2. andrey-qlogic commented on Jan 18, 2019

   

   andrey-qlogic

   on Jan 18, 2019

   Contributor

   More actions

   @chingor13 , is there any update on this feature request?
3. andrey-qlogic

   self-assigned this

   on Mar 11, 2019
4. dhoard commented on Mar 12, 2019

   

   dhoard

   on Mar 12, 2019

   More actions

   @chingor13 thoughts on providing a setContentTypeMapping(Map<String, String> map) on StorageOptions.Builder to setup an blob name extension to content-type mapping?

   It would be completely optional and shouldn't breaking any existing code.
5. andrey-qlogic commented on Mar 14, 2019

   

   andrey-qlogic

   on Mar 14, 2019

   Contributor

   More actions

   @chingor13 , @dhoard
   I would assume that we can add something like the example below
   similar to https://github.com/googleapis/google-cloud-java/blob/35cc9874ce2963ca9d66aa0d584208a59154b6f3/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L611

   public final String getContentType() {
       if (headerProvider != null) {
         for (Map.Entry<String, String> entry : headerProvider.getHeaders().entrySet()) {
           if ("content-type".equals(entry.getKey().toLowerCase())) {
             return entry.getValue();
           }
         }
       }
       return null;
     }
6. dhoard commented on Mar 14, 2019

   

   dhoard

   on Mar 14, 2019

   More actions

   @andrey-qlogic conceptually that might work. From an implementation standpoint, it would be better to perform a get() on the headerProvider ...

   public final String getContentType() {
       String contentType = null;
   
       if (headerProvider != null) {
           contentType = headerProvider.get("content-type");
       }
   
       return contentType;
   }
   

   @chingor13 your feedback?
7. sduskis

   unassigned

   andrey-qlogic

   on Jun 11, 2019
8. chingor13

   transferred this issue fromgoogleapis/google-cloud-javaon Jan 7, 2020
9. chingor13

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   on Jan 7, 2020
10. gcf-label-sync

    added

    api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.

    on Jan 29, 2020
11. dmitry-fa

    self-assigned this

    on May 20, 2020
12. dmitry-fa commented on May 20, 2020

    

    dmitry-fa

    on May 20, 2020

    Last edited by athakor

    Contributor

    More actions

    Similar fix in nodejs: googleapis/nodejs-storage#1190
13. frankyn

    closed this as completedin #338on Jul 15, 2020