Skip to content

Marshal 'BYTES' and 'TIME' column / paramter types - #2806

Merged
tseaver merged 8 commits into
googleapis:masterfrom
tseaver:2229-bigquery-marshal-bytes-time-types
Dec 5, 2016
Merged

Marshal 'BYTES' and 'TIME' column / paramter types#2806
tseaver merged 8 commits into
googleapis:masterfrom
tseaver:2229-bigquery-marshal-bytes-time-types

Conversation

@tseaver

@tseaver tseaver commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Closes #2229.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
daspecster
daspecster reviewed Dec 5, 2016
View reviewed changes
Comment thread bigquery/google/cloud/bigquery/_helpers.py
def _date_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in YYYY-MM-DD form.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

daspecster
daspecster reviewed Dec 5, 2016
View reviewed changes
Comment thread bigquery/google/cloud/bigquery/_helpers.py
def _time_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in HH:MM:SS form.

This comment was marked as spam.

Sign in to view

dhermes
dhermes approved these changes Dec 5, 2016
View reviewed changes
Comment thread bigquery/google/cloud/bigquery/_helpers.py
def _date_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in YYYY-MM-DD form.

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Dec 5, 2016

Copy link
Copy Markdown
Contributor Author

I will merge as soon as either Circle CI or Travis passes the Py3k fix I just pushed.

@tseaver tseaver mentioned this pull request Dec 5, 2016
Closed
@tseaver

tseaver commented Dec 5, 2016

Copy link
Copy Markdown
Contributor Author

Travis is showing build failures for docs which don't happen on Circle or on my local machine.

@tseaver
tseaver merged commit 6916814 into googleapis:master Dec 5, 2016
@tseaver
tseaver deleted the 2229-bigquery-marshal-bytes-time-types branch December 5, 2016 19:42
@dhermes dhermes mentioned this pull request Dec 5, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#2806 from tseaver/2229-bigquery-marshal…
024ea0a 
…-bytes-time-types

Marshal 'BYTES' and 'TIME' column / paramter types
atulep pushed a commit that referenced this pull request Apr 6, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
7f99576 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
6cec481 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
c13082f 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
5fe5a73 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
69fd623 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
eb494f5 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@kurtisvg @renovate-bot @busunkim96
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
d9da51d 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecster daspecster daspecster left review comments
@dhermes dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @daspecster @dhermes @googlebot