Repository navigation
double leading slash when uploading a file to a bucket #1972
Description
Environment details
- OS: GKE
- Node.js version: 7
- npm version: 4.0.5
- google-cloud-node version: "@google-cloud/storage": "^0.5.0"
Steps to reproduce
const bucket = Storage().bucket('gs://my-name')
const file = bucket.file('/foo/bar/lol.txt')
const readStream = fs.createReadStream('./lol.txt')
const writeStream = file.createWriteStream({ metadata: { contentType: 'text/plain' } })
readStream.pipe(writeStream)Given the above code it uploads a file at gs://my-name//foo/bar/lol.txt
Activity
stephenplusplus commentedon Feb 7, 2017
The bucket name should simply be
my-name, not its URL:And same for the file method:
With these changes, the file uploaded should land at:
gs://my-name/foo/bar/lol.txt.I don't think it'd be a big change if our library auto-removed any leading slashes from the input to
bucket.file(), but given the explanation above of the correct way to use these methods, do you think it's necessary?kilianc commentedon Feb 7, 2017
@stephenplusplus I was using only
my-nameindeed, I messed up while trying to extract the use case.Since I am not feeding the library anywhere a double leading slash it is very strange that this is the outcome. I mean
my-name+/foo->my-name/foo. I understand the other way around where in case of a missing leading slash it's assumed the user means root.In my opinion this is straight up a bug, I can't think of anybody that needs to upload a file to
something//file.txtIMHO.🍻
stephenplusplus commentedon Feb 7, 2017
You're right, that is weird. I'll mark as
help wanted, so if anybody wants to strip leading/from within theFileconstructor, please help!stephenplusplus commentedon Feb 7, 2017
Oh, and 🍻
kilianc commentedon Feb 7, 2017
I am looking at the code, I'll def try to help
fix(deps): update dependency @google-cloud/pubsub to v3 (#1972)
build: shift typeless bot invocation into library package (#1972)
fix(deps): update dependency @google-cloud/pubsub to v3 (googleapis#1972