Repository navigation
Split XJC code into separate subproject - #3244
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
f1a72dd to
718308e
Compare
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
718308e to
5165216
Compare
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu partially reviewed 116 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman and jicelhay).
settings.gradle line 44 at r1 (raw file):
include 'testing' include 'util' include 'xjc'
nit: We should probably name this folder eppbindings or something similar.
Code quote:
'xjc'
The generated XML / XJC code pretty much never changes but because everything is lumped together in one compile task, we had to recompile this every time anything else in core/ changes. It's technically possible to use a separate source set for the XJC code while having it remain in core/, but splitting it into a separate subproject gives better separation and makes the caching / dependency graph clearer. Pretty much all, except for the caching configuration, of the new xjc/build.gradle is taken from the previous core/build.gradle.
5165216 to
4283f20
Compare
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment and resolved 1 discussion.
Reviewable status: 8 of 116 files reviewed, all discussions resolved (waiting on jicelhay and weiminyu).
settings.gradle line 44 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
nit: We should probably name this folder eppbindings or something similar.
Done
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
The generated XML / XJC code pretty much never changes but because everything is lumped together in one compile task, we had to recompile this every time anything else in core/ changes. It's technically possible to use a separate source set for the XJC code while having it remain in core/, but splitting it into a separate subproject gives better separation and makes the caching / dependency graph clearer.
Pretty much all, except for the caching configuration, of the new xjc/build.gradle is taken from the previous core/build.gradle.
This change is