Simplify, cleanup and update docker files - #763
Conversation
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 48.42% 48.42%
=======================================
Files 28 28
Lines 2480 2480
=======================================
Hits 1201 1201
Misses 1093 1093
Partials 186 186Continue to review full report at Codecov.
|
liamsi
changed the title
| RUN apt-get update && apt-get install -y libtool libltdl-dev | ||
| RUN go get -tags="mysql" ./cmd/keytransparency-server | ||
|
|
||
| ENTRYPOINT /go/bin/keytransparency-server \ |
There was a problem hiding this comment.
We need to set an entry point. Otherwise, it's not possible to add additional arguments via the docker command line.
There was a problem hiding this comment.
docker-compose and kubernetes work though. I'll add an ENTRYPOINT in case someone wants to use the images with any these. Thanks
| - --map-id=$MAP_ID | ||
| - --map-url=trillian-map:8090 | ||
| - --vrf=/kt/vrf-key.pem | ||
| - --key=/kt/server.key |
There was a problem hiding this comment.
Would you mind renaming this flag and the following to tls-key and tls-cert ?
gdbelvin
left a comment
gdbelvin
left a comment
There was a problem hiding this comment.
Do the Kube scripts need to be updated as well?
Cleans up a few off by on errors and poor stopping condition logic in the list history command. Fixes google#763
|
I've updated the kube scripts as well. Will rebase. Then this is ready for another review. |
# Conflicts: # cmd/keytransparency-signer/Dockerfile # cmd/keytransparency-signer/main.go # docker-compose.yml
3 participants
Changes:
It could make sense to wait for #762 to be merged first (removes --log-key flag).
Tested locally.
Travis fails because of some dependency in vendored code in trillian:https://travis-ci.org/google/keytransparency/builds/265725916#L639-L640
Fixed with google/trillian@a1b0c2d and google/trillian@b144701
closes #712