Repository navigation
Prometheus - #589
Prometheus#589
Conversation
1568980 to
40b74ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 56.95% 56.76% -0.19%
==========================================
Files 35 35
Lines 2472 2489 +17
==========================================
+ Hits 1408 1413 +5
- Misses 775 787 +12
Partials 289 289
Continue to review full report at Codecov.
|
|
|
||
| return resp, err | ||
| } | ||
|
|
|
|
||
| // Put SignedMapHead in an append only log. | ||
| if err := s.sths.Write(ctx, s.logID, setResp.MapRoot.MapRevision, setResp.MapRoot); err != nil { | ||
| // TODO: sths.Write currently hangs. |
There was a problem hiding this comment.
// TODO: sths.Write currently hangs.
Is this still true? If yes, change to TODO(name): else remove.
| image: prom/prometheus | ||
| volumes: | ||
| - ./prometheus.yml:/etc/prometheus/prometheus.yml | ||
| - ./prometheus.rules:/etc/prometheus/prometheus.rules |
There was a problem hiding this comment.
Can't we just ADD/COPY these files in a separate Dockerfile? The prometheus container would be self-contained and this would save us some pain when running this on GCE with kubernetes.
| ) | ||
|
|
||
| var ( | ||
| timeout = 10 * time.Second |
There was a problem hiding this comment.
Should this timeout be a commandline flag? Are 10s always a reasonable timeout?
There was a problem hiding this comment.
removed and replaced with minInterval
40b74ac to
027c19a
Compare
| VRF_PUB: /kt/genfiles/vrf-pubkey.pem | ||
| SIGN_KEY: /trillian/log-rpc-server.privkey.pem | ||
| SIGN_KEY_PW: towel | ||
| SIGN_PERIOD: 5s |
There was a problem hiding this comment.
The corresponding flag got renamed to --min-period for the signer. I would suggest to name this MIN_SIGN_PERIOD (Already fixed in #607: https://github.com/Liamsi/keytransparency/blob/6d3dde3ce28615df44bb80ac2076307c6e572362/cmd/keytransparency-signer/Dockerfile#L26).
If this gets merged before #607, please update the flag in the Dockerfile (otherwise docker-compose won't succeed starting the kt-signer).
- grpc interceptor for kt-server. - metrics framework for kt-signer. - renamed main files to match go standards. Closes google#481
- Adds signer metrics - Closes google#587
|
Updated PTAL |
Merge #578 first.
Adds prometheus monitoring
Fixes #610