Keep job tasks when toggling free-form data collection - #2599
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the job strategy change handling in EditJobComponent to fetch the job directly from the draft survey service, introduces validation in DraftSurveyService to mark jobs with empty tasks as invalid, and adds unit tests for updateLoiTasks. The review feedback points out a potential bug where this.addLoiTaskId can leak across different jobs and suggests defensively guarding against undefined this.jobId instead of using non-null assertions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2599 +/- ##
==========================================
+ Coverage 62.94% 63.10% +0.16%
==========================================
Files 121 121
Lines 3006 3011 +5
Branches 457 459 +2
==========================================
+ Hits 1892 1900 +8
+ Misses 1048 1046 -2
+ Partials 66 65 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
closes #2598