Skip to content

Add a flag for cmake to generate IE11 compatible JS decoder modules - #405

Merged
tomfinegan merged 1 commit into
google:masterfrom
ggetz:ie-compatibility-js-decoder
Jun 8, 2018
Merged

tomfinegan merged 1 commit into
google:masterfrom
ggetz:ie-compatibility-js-decoder

Conversation

@ggetz

@ggetz ggetz commented May 25, 2018

Copy link
Copy Markdown
Contributor

The current JavaScript decoder module fails when run in IE11.

This allows an IE_COMPATIBLE variable to be set when generating the cmake files in order to build a module that works in IE11 by providing polyfills, at a small hit to module size (1MB), with the solution proposed in emscripten-core/emscripten#6204

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ggetz

ggetz commented May 25, 2018

Copy link
Copy Markdown
Contributor Author

I've signed the CLA

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@tomfinegan tomfinegan self-assigned this Jun 7, 2018
@tomfinegan
tomfinegan merged commit 83cbf6c into google:master Jun 8, 2018
@ggetz
ggetz deleted the ie-compatibility-js-decoder branch June 8, 2018 16:17
danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
Add a flag for cmake to generate IE11 compatible JS decoder modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants