Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
Member
|
Review comments on https://dawn-review.googlesource.com/c/dawn/+/342595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature generator treats by-value WGPUStringView arguments as unsupported structures, causing their generated
__sigentries to be commented out.Under MEMORY64, this prevents Emscripten from generating BigInt-to-Number pointer conversions for affected JavaScript bindings.
Calling PushDebugGroup or InsertDebugMarker consequently throws:
The exception occurs in makeStringFromStringView when it performs Number arithmetic on the incoming BigInt address.
Recognise by-value WGPUStringView arguments as pointers, matching their indirect passing convention in the Wasm C ABI. This generates the required
vppsignatures for the debug-group and marker functions. Structure return values and other structure types remain unchanged.Validation:
vpp.