Repository navigation
Conversation
Previously, an abstract method from an `implementing` (or `extending`) type that did not match any factory `create` overload still produced a forwarding stub of the form `return create(args)`. When the interface method itself was named `create`, that stub called itself and caused a StackOverflowError at runtime — typically after forgetting `@Provided` on a constructor parameter (issue google#697). Fail compilation with a diagnostic that explains the mismatch and points at `@Provided`, and add a negative compilation test for the reported case.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@AutoFactory(implementing = …)(orextending) abstract method has no matching factorycreateoverload, AutoFactory used to emit a forwarding stubreturn create(args).create, the stub called itself and threwStackOverflowErrorat runtime. The usual trigger is forgetting@Providedon a constructor parameter, which silently turns that parameter into an extra factory argument (fixes AutoFactory: missing @Provided leads to StackOverflowError #697).@Provided, instead of generating the recursive stub.Test plan
mvn testinfactory/—AutoFactoryProcessorTest185 tests (7 skipped),AutoFactoryProcessorNegativeTestincluding newmissingProvidedLeadsToUnmatchedInterfaceMethodmvn verifyinfactory/— unit tests + invoker ITs passed@AutoFactory(implementing = Factory.class)with a missing@Provided) and confirm a clear error on@AutoFactoryrather than a runtime StackOverflowError