Harden MjrContext cleanup after failed construction - #547
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Harden MjrContext cleanup after failed construction#547sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Addresses the secondary cleanup failure reported in google-deepmind#370.
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
MjrContextcleanup safe when renderer construction fails before the GL context reference count is acquired.Changes
_ptrand track whether thisMjrContextactually acquired a GL-context referenceptrandfree()safe for partially initialized instancesRationale
The framebuffer/context failure reported in #370 can trigger a secondary cleanup exception because
__del__()runs on a partially initializedMjrContext. It can also attempt to decrement a GL-context reference count that this object never incremented. This patch addresses that cleanup path only; it does not claim to fix the underlying EGL/framebuffer failure.Related to #370.