Repository navigation
ci: build the landing page on pull requests too - #4
Merged
Merged
Conversation
The workflow ran only on pushes to main, so a pull request touching the layout, the content or the Hugo version got no signal at all -- its checks read "no checks", which is not the same thing as green. Two changes, and only two: a pull_request trigger so the existing build job runs on every PR, and a guard on deploy so a pull request stops after building and uploading the artifact rather than replacing what is served. This file puts `environment:` before `needs:`, an ordering the other 192 landing pages do not use. The transform was taught that second shape rather than these three being edited by hand, and it still refuses anything it does not recognise -- an already-gated file is refused, and the 192 produce byte-identical output to before. Checked while here: HUGO_VERSION is pinned at 0.135.0, the same stale pin that had frozen go-filesystems.github.io at 15 cards when its template started using hugo.Data. This site does NOT use hugo.Data, builds identically on 0.135.0 and 0.162.1, and the live page matches the built output, so the pin is harmless here and is left alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow ran only on pushes to main, so a pull request touching the layout, the content or the Hugo version got no signal at all — its checks read "no checks", which is not the same thing as green.
Two changes, and only two
pull_requesttrigger, so the existingbuildjob runs on every PR.deploy, so a pull request stops after building and uploading the artifact rather than replacing what is served.Why this one was not in the batch of 192
This file puts
environment:beforeneeds:— an ordering the other 192 landing pages do not use, so the transform refused it rather than editing a shape it did not recognise. The tool was taught the second shape rather than these three being hand-edited, and it still refuses anything else: an already-gated file is refused, and the 192 produce byte-identical output to before.Checked while here, and deliberately not changed
HUGO_VERSIONis pinned at 0.135.0 — the same stale pin that had frozengo-filesystems.github.ioat 15 cards once its template started usinghugo.Data.This site does not use
hugo.Data, builds identically on 0.135.0 and 0.162.1, and the live page matches the built output. The pin is harmless here, so it is left alone rather than churned.🤖 Generated with Claude Code