Repository navigation
ci: pin Go 1.27.1 instead of stable - #7
Merged
Merged
Conversation
`stable` is a channel, not a version, so the toolchain moved here with no commit: CI has been building and running on go1.27.1 while go.mod said otherwise, and a MINOR Go bump is the one that reindents under gofmt and changes coverage block counting. It also kept the shared Renovate rule from ever firing. That rule matches dep name `go` under the `gomod` and `github-actions` managers with `automerge: false`, citing golang/go#81000 — and an alias has no version to compare or rewrite. Pinning is what makes the review rule apply at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-version: stableis a channel alias, not a version, so this repository has been built and run ongo1.27.1with nothing in the tree saying so — and a minor Go bump is the one that reindents undergofmtand changes coverage block counting.It also kept the shared Renovate rule from ever firing: that rule matches dep name
gounder thegomodandgithub-actionsmanagers withautomerge: false, citinggolang/go#81000, and an alias has no version to compare or rewrite. Pinning is the condition for the review rule to apply at all, not rigidity.What to check before merging
CI is the control, and two lanes are worth a glance:
gofmt, if this repository gates it. A minor Go bump reindents; a patch does not.loong64under qemu, if this repository runs it.golang/go#81147, the 1.27 backport of the loong64 miscompile, is still open (milestone Go1.27.2) — verified in the released toolchain, whereLOONG64.rulesstill maps(Cvt64Fto32 ...)to(TRUNCDW ...)with all four float-to-integer ops declaredreg: fp11. A repository that only cross-compiles for loong64 cannot tell the difference, because a code-generation defect cannot redden a build that never runs.Pushed with
gitpush, because a workflow file cannot be written through the contents API with the tokenghholds: that one has noworkflowscope, and GitHub answers the PUT with a bare 404 naming neither.🤖 Generated with Claude Code