Repository navigation
ci(docs): build on pull requests, and serialise the gh-pages deploy - #5
Merged
Merged
Conversation
This workflow ran only on main, so a dependency bump here had no signal at
all: three Renovate pull requests are open against this repository and not
one of them has a single check. Nothing can say whether they are safe to
merge, and merging them blind is how a broken toolchain lands.
Build on pull_request as well. The deploy job is unchanged except that it
now waits on the build and runs only for push or workflow_dispatch -- a
pull request has no business pushing to gh-pages, and a fork's PR is not
granted `contents: write` anyway.
The deploy also gets a concurrency group. Two `mike deploy --push` runs at
once end with
! [rejected] gh-pages -> gh-pages (fetch first)
and cancel-in-progress stays false deliberately: killing a publish half way
through is worse than making it wait, and the queued run then fetches the
gh-pages the previous one just wrote.
Verified before pushing: `mkdocs build --strict` exits 0 against this tree
in a python:3.12-slim container, so the new job lands green rather than red.
The Python and setup-python versions are left exactly as they are -- the
open Renovate PRs propose those, and they can now be judged on their own
checks.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow ran only on main, so a dependency bump here has no signal at all: three Renovate pull requests are open against this repository and not one of them has a single check. Nothing can say whether they are safe to merge, and merging them blind is how a broken toolchain lands.
The change
pull_requestas well as onmain.deployis unchanged except that it nowneeds: buildand runs only forpushorworkflow_dispatch— a pull request has no business pushing togh-pages, and a fork's PR is not grantedcontents: writeanyway.deploygets a concurrency group. Twomike deploy --pushruns at once end with! [rejected] gh-pages -> gh-pages (fetch first);cancel-in-progressstays false deliberately, since killing a publish half way through is worse than making it wait.Verified before pushing
mkdocs build --strictexits 0 against this tree in apython:3.12-slimcontainer, so the new job lands green rather than immediately red.actionlintreports nothing on the file.The Python and
setup-pythonversions are left exactly as they are — the open Renovate PRs propose those bumps, and once this lands they can be judged on their own checks instead of merged blind.How this was found
A sweep for open dependency PRs with no checks at all. Most turned out to be PRs whose lane simply predated its
pull_requesttrigger and only neededgh pr update-branch; this repository is one of the few where the trigger genuinely does not exist.