Repository navigation
Bump the conformance guard to docs v0.4.0, where its flag became --root - #24
Merged
Merged
Conversation
The tool this step runs moved to cobra in go-embedded-ruby/docs#36, so its flags are POSIX --long now. ⛔ THE VERSION AND THE FLAG MOVE TOGETHER, and that is the point. `-root` is not a shorter spelling of `--root`: pflag reads it as the cluster -r -o -o -t, and the step fails with conformancefigure: unknown shorthand flag: 'r' in -root A bump that changed only the version would have met that during some later upgrade with nothing to do with it -- which is the worst shape for a breaking change, silent until an unrelated routine touch. docs#33 was filed to make this wave deliberate instead. VERIFIED BEFORE BUMPING, not after: the tool at that version was run against this repository's layouts/ and reads this page's phrasing -- 4 current claim(s) checked against the gate's 23511 which matters because the vocabulary it uses was EXTENDED for this page's HTML style ("<b>23,511</b> … examples passing"), and a vocabulary that stops matching reports no disagreement, exactly like a page with no stale figures. The same reason is why conformancefigure keeps its vocabulary control INSIDE the tool rather than moving it to a _test.go as its sibling did: this consumer runs `go run …@vX` and never runs that module's tests, so a control living only in a test would have silently stopped protecting this page. The pin stays a TAG. The comment above it already says why -- @main is whatever the proxy last cached, and that lag once failed a branch whose figures were right. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conformance guard this page runs moved to cobra in go-embedded-ruby/docs#36, so its flags are POSIX
--longnow.⛔ The version and the flag move together, and that is the point
-rootis not a shorter spelling of--root.pflagreads it as the cluster-r -o -o -t:A bump that changed only the version would have met that during some later upgrade with nothing to do with it — silent until an unrelated routine touch, which is the worst shape a breaking change can take. docs#33 was filed to make this wave deliberate instead of accidental.
Verified before bumping, not after
The tool at that version was run against this repository's
layouts/:That check matters more than it looks. The vocabulary this tool matches on was extended for this page's HTML style (
<b>23,511</b> … examples passing), and a vocabulary that stops matching reports no disagreement — indistinguishable from a page with no stale figures.It is also why
conformancefigurekeeps its vocabulary control inside the tool, running on every invocation, rather than moving it into a_test.goas its siblingdocexampledid: this consumer runsgo run …@vXand never runs that module's tests. A control living only in a test would have quietly stopped protecting this page.The pin stays a tag
The comment above the step already explains why, and nothing here changes it:
@mainis whatever the module proxy last cached for the branch, and that lag once failed a branch whose figures were right.🤖 Generated with Claude Code