This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Timing could lead to unresponsive bot #5
Description
Activity
maybe we abandon verifying things with
check_suite.completed. In cases like this we may be able to use the pull request name from within thecheck_suiteevent. Take a look at the object below, you'll see the PR name."check_suite": { "id": 118578147, "node_id": "MDEwOkNoZWNrU3VpdGUxMTg1NzgxNDc=", "head_branch": "changes", "head_sha": "ec26c3e57ca3a959ca5aad62de7213c562f8c821", "status": "completed", "conclusion": "success", "url": "https://api.github.com/repos/Codertocat/Hello-World/check-suites/118578147", "before": "6113728f27ae82c7b1a177c8d03f9e96e0adf246", "after": "ec26c3e57ca3a959ca5aad62de7213c562f8c821", "pull_requests": [ { "url": "https://api.github.com/repos/Codertocat/Hello-World/pulls/2", "id": 279147437, "number": 2, "head": { "ref": "changes", "sha": "ec26c3e57ca3a959ca5aad62de7213c562f8c821", "repo": { "id": 186853002, "url": "https://api.github.com/repos/Codertocat/Hello-World", "name": "Hello-World" }
Drilling down deep enough to get the name may pose a challenge for what we can do with Learning Lab though.
Suppose the following series of steps:
check_suite.completedevent comes through (which should trigger the following step, but LL doesn't know we're there yet)check_suite.completedevent that'll never come through.I'm not sure the best way to handle this edge case, but it's also present in our other Actions and Apps courses.