fix: allow community submission archive validation by mnriem · Pull Request #4622 · github/spec-kit

mnriem · 2026-09-17T18:50:35Z

Description

Closes #4589.

Run 34898212927 denied the archive curl command because it was absent from the shell tool allowlist. The resolved firewall configuration also omitted codeload.github.com and release-assets.githubusercontent.com, so permitting the command alone would leave the accepted download URLs blocked at their redirect destinations.

Permit curl and only the required GitHub download hosts alongside the existing default network policy in the extension, preset, and bundle submission workflows, which share the same validation requirements and configuration gap.
Require HTTPS-only redirects, a 60-second timeout, and direct archive HTTP evidence; blocked requests or repository/release metadata cannot count as successful downloads. Downloaded content must not be executed.
Regenerate the three workflow locks and add regression coverage for tool permissions, redirect hosts, and direct-evidence instructions. Existing repository/tag pinning checks, optional checksum validation, action pins, read-only permissions, and safe-output restrictions are preserved.

Testing

Tested locally with uv run specify --help
Ran existing tests with uv sync && uv run pytest
Tested with a sample project (if applicable)

Workflow-only change; CLI/sample-project checks and the full suite were not run. Targeted validation used this worktree's own virtualenv:

.venv/bin/python -m pytest tests/test_github_workflows.py -q: 37 passed. All three new regression checks failed before the fix.
gh aw compile add-community-extension add-community-preset add-community-bundle --strict --no-check-update: all three compiled with zero errors or warnings using v0.88.7, matching their compiler metadata and the version enforced by the workflow regression tests.
Semantic comparison of the generated workflows confirmed only download-domain configuration and the curl tool permission changed; existing action/container pins and policies remain unchanged.
A direct GET of the reported archive returned HTTP 200 after redirecting to codeload.github.com.
git diff --check passed.

The hosted workflow has not been rerun; end-to-end confirmation is needed after merge and a new submission-label trigger.

AI Disclosure

I did not use AI assistance for this contribution
I did use AI assistance (describe below)

GitHub Copilot (model: GPT-6 Astra), acting on behalf of @mnriem, investigated the run, authored the fix and regression coverage, and performed the local validation autonomously. @mnriem requested the work and authorized the commit and upstream PR; the changes have not been represented as human-authored or line-by-line human-reviewed.

Copilot

Copilot review overview

🟡 Changes recommended

The bundle workflow unnecessarily allows codeload access despite accepting only release assets.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

Remove unnecessary codeload access from bundle validation · New
Model redirect hosts per workflow · New

What changed in this PR

Enables direct archive validation in community submission workflows while constraining downloads to HTTPS GitHub hosts.

Changes:

Allows curl and GitHub archive redirect hosts.
Adds timeout, status verification, and non-execution safeguards.
Regenerates workflow locks and adds regression tests.

File	Description
`.github/workflows/add-community-extension.md`	Enables guarded archive downloads.
`.github/workflows/add-community-extension.lock.yml`	Regenerates the extension workflow.
`.github/workflows/add-community-preset.md`	Enables guarded archive downloads.
`.github/workflows/add-community-preset.lock.yml`	Regenerates the preset workflow.
`.github/workflows/add-community-bundle.md`	Enables release-asset downloads.
`.github/workflows/add-community-bundle.lock.yml`	Regenerates the bundle workflow.
`tests/test_github_workflows.py`	Verifies permissions, hosts, and download safeguards.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

mnriem · 2026-09-18T20:06:22Z

Addressed the review in commit 828822b0.

Removed codeload.github.com from the bundle workflow source and generated lock while preserving the release-asset redirect host.
Changed the regression to model redirect hosts per workflow and verify unnecessary hosts are absent from compiled agent configuration.
Validated with .venv/bin/python -m pytest tests/test_github_workflows.py -q (14 passed) and git diff --check.

Posted on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol).

Copilot

Copilot review overview

🟡 Changes recommended

Two regression assertions can miss removal of the executable curl permission or redirect-following flag.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Check the executable curl permission, not its generated comment · New

Resolved since last review (2)

Model redirect hosts per workflow
Remove unnecessary codeload access from bundle validation

Permit curl and the GitHub archive/release redirect hosts in all three community submission workflows. Require direct download evidence, preserve existing pinning checks, and cover the source and compiled configuration with regression checks. Closes github#4589 Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove codeload.github.com from bundle validation while retaining it for extension and preset tag archives. Model the required redirect hosts per workflow in regression coverage and update the generated bundle lock without compiler drift. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Inspect the non-comment Copilot harness command before asserting the curl tool permission, and require the explicit curl redirect-following flag in archive guidance. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

mnriem · 2026-09-18T20:24:36Z

Rebased the branch onto current upstream/main and addressed the latest review in commit c2e24d84.

The curl permission regression now extracts the single non-comment copilot_harness.cjs command before asserting shell(curl:*), so the generated tool-inventory comment cannot mask a missing executable argument.
The archive guidance regression now requires --location together with the HTTPS protocol restrictions.
Regenerated the community workflow locks with the upstream v0.88.7 compiler during conflict resolution.
Validated with .venv/bin/python -m pytest tests/test_github_workflows.py -q (37 passed) and git diff --check.

Posted on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol).

Copilot

Copilot review overview

🟢 Approval recommended

The implementation and regression coverage are consistent; only the PR’s stated compiler version needs correction.

Review effort: Balanced
Findings: 1

Open (1)

Correct testing disclosure to reflect gh-aw v0.88.7 validation · New

Resolved since last review (1)

Check the executable curl permission, not its generated comment

mnriem · 2026-09-18T20:39:24Z

Addressed the latest review by correcting the PR testing disclosure. It now records gh-aw v0.88.7, matching the generated lock metadata and regression enforcement, and the current targeted result of 37 passed.

No code change was required; the branch head remains c2e24d84.

Posted on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol).

Copilot

Copilot review overview

🟢 Approval recommended

The focused workflow fix is consistently applied, reflected in generated locks, and protected by targeted regression tests.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Correct testing disclosure to reflect gh-aw v0.88.7 validation

Copilot AI balanced review requested due to automatic review settings September 17, 2026 18:50

Copilot started reviewing on behalf of mnriem September 17, 2026 18:51 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Comment thread .github/workflows/add-community-bundle.md Outdated

Comment thread tests/test_github_workflows.py Outdated

mnriem added the triage-must-have Verdict: high-value, important work for Spec Kit — do first label Sep 17, 2026

Copilot AI review requested due to automatic review settings September 18, 2026 20:06

Copilot started reviewing on behalf of mnriem September 18, 2026 20:06 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread tests/test_github_workflows.py Outdated

mnriem and others added 3 commits September 18, 2026 15:23

Copilot AI review requested due to automatic review settings September 18, 2026 20:24

mnriem force-pushed the mnriem-archive-validation-access branch from 828822b to c2e24d8 Compare September 18, 2026 20:24

Copilot started reviewing on behalf of mnriem September 18, 2026 20:25 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread .github/workflows/add-community-extension.lock.yml

mnriem requested a balanced review from Copilot September 18, 2026 20:39

Copilot started reviewing on behalf of mnriem September 18, 2026 20:40 View session

mnriem merged commit 130480b into github:main Sep 18, 2026
15 checks passed

mnriem deleted the mnriem-archive-validation-access branch September 18, 2026 20:40

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Navigation Menu

fix: allow community submission archive validation - #4622

fix: allow community submission archive validation#4622
mnriem merged 3 commits into
github:mainfrom
mnriem:mnriem-archive-validation-access

mnriem commented Sep 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mnriem commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

AI Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Uh oh!

mnriem commented Sep 18, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mnriem commented Sep 17, 2026 •

edited

Loading