Fix paths-only validation in check-prerequisites - #2571
Open
prantikmedhi wants to merge 2 commits into
Open
prantikmedhi wants to merge 2 commits into
prantikmedhi wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes check-prerequisites paths-only mode so branch validation is skipped before returning path data, matching the documented “no validation” behavior.
Changes:
- Moves branch validation after the paths-only early exit in Bash and PowerShell scripts.
- Adds regression tests for
--paths-only/-PathsOnlyon a non-feature branch.
Show a summary per file
| File | Description |
|---|---|
scripts/bash/check-prerequisites.sh |
Defers feature-branch validation until after paths-only output. |
scripts/powershell/check-prerequisites.ps1 |
Mirrors the Bash validation ordering for PowerShell. |
tests/test_check_prerequisites_paths_only.py |
Adds Bash and PowerShell regression coverage for paths-only branch-validation skipping. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 4
Collaborator
|
Please address Copilot feedback. If not applicable, please explain why |
Author
|
Addressed the Copilot feedback in the regression test fixture:
Validation: |
Comment on lines
+21
to
+22
| env.pop("SPECIFY_FEATURE", None) | ||
| env.pop("SPECIFY_FEATURE_DIRECTORY", None) |
Comment on lines
+29
to
+33
| subprocess.run(["git", "init", "-q", "--initial-branch", "main"], cwd=tmp_path, check=True) | ||
| subprocess.run(["git", "config", "user.email", "test@example.com"], cwd=tmp_path, check=True) | ||
| subprocess.run(["git", "config", "user.name", "Test User"], cwd=tmp_path, check=True) | ||
| subprocess.run(["git", "commit", "--allow-empty", "-m", "init", "-q"], cwd=tmp_path, check=True) | ||
|
|
Comment on lines
+55
to
+58
| payload = json.loads(result.stdout) | ||
| assert payload["BRANCH"] == "main" | ||
| assert payload["FEATURE_DIR"].endswith("specs/001-test") | ||
|
|
Comment on lines
+71
to
+74
| assert result.returncode == 0, result.stderr | ||
| payload = json.loads(result.stdout) | ||
| assert payload["BRANCH"] == "main" | ||
| assert payload["FEATURE_DIR"].endswith("specs/001-test") |
mnriem
requested changes
May 27, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback and resolve conflicts
Contributor
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed in 30 days if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2477.
Validated with: