feat(release): support Linux arm64 detector builds#556
Closed
davidslater wants to merge 1 commit into
Closed
Conversation
Build both threat-detect-linux-amd64 and threat-detect-linux-arm64 in the release and publish-main workflows, recording each asset's sha256 in the release notes. Promote verifies both per-arch assets against the recorded digests. Consumers (detection-only, replay-detection, and the generated container smoke siblings) now detect the runner architecture via `uname -m` and download the matching asset. Docs updated accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Linux arm64 release support alongside amd64 and selects architecture-specific binaries at runtime.
Changes:
- Builds, publishes, checksums, and verifies both architectures.
- Makes detector consumers architecture-aware.
- Updates generated workflows and documentation.
Show a summary per file
| File | Description |
|---|---|
scripts/create-threat-detection-sibling-workflows.py |
Generates architecture-aware downloads. |
README.md |
Documents dual-architecture assets. |
DEVGUIDE.md |
Updates release guidance. |
CLAUDE.md |
Updates repository architecture guidance. |
.github/workflows/smoke-copilot-container.lock.yml |
Selects the Copilot smoke asset by architecture. |
.github/workflows/smoke-claude-container.lock.yml |
Selects the Claude smoke asset by architecture. |
.github/workflows/smoke-codex-container.lock.yml |
Selects the Codex smoke asset by architecture. |
.github/workflows/replay-detection.yml |
Fetches the matching replay detector. |
.github/workflows/release.yml |
Builds and publishes both architectures. |
.github/workflows/publish-main.yml |
Publishes dual-architecture edge assets. |
.github/workflows/promote-release.yml |
Verifies both assets before promotion. |
.github/workflows/detection-only.yml |
Selects the matching detector asset. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 12/12 changed files
- Comments generated: 1
- Review effort level: Medium
| case "$(uname -m)" in | ||
| x86_64) asset=threat-detect-linux-amd64 ;; | ||
| aarch64|arm64) asset=threat-detect-linux-arm64 ;; | ||
| esac |
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Linux arm64 support so the detector runs on different runner architectures, not just amd64.
Changes
Build & publish
release.ymlandpublish-main.ymlnow build boththreat-detect-linux-amd64andthreat-detect-linux-arm64, add both tochecksums.txt, and record each binary's sha256 in the release notes using per-arch lines:Binary asset sha256 (linux-<arch>): sha256:<hash>.Promotion
promote-release.ymlre-downloads and verifies both per-arch assets against their recorded digests before marking a release Latest.Arch-aware consumers
detection-only.yml,replay-detection.yml, and the container smoke siblings now detect the runner arch viauname -m(x86_64→amd64,aarch64|arm64→arm64) and download the matching asset.scripts/create-threat-detection-sibling-workflows.pyemits the arch-aware download shell;*-container.lock.ymlfiles regenerated.Docs
Verification
make buildpasses; sibling--checkis clean; edited workflow YAML parses.