Repository navigation
[Copilot Dreams] Keep localization rules in one place #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
37a00a2
37f7450
80a1303
03d2d9b
f4d30c8
7cfe185
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,20 +114,17 @@ Translate human-language prose, including comments inside code blocks where they | |
|
|
||
| ### Translator agent | ||
|
|
||
| Use the `translator` agent to perform the localization. It should follow the rules and guidelines defined for each target locale document in the `rules` directory. | ||
| The `translator` agent should follow the rules and guidelines defined for each target locale document in the `rules` directory. | ||
|
|
||
| ### Evaluator agent | ||
|
|
||
| Use the `evaluator` agent to assess the quality of the localized content. The evaluator checks for accuracy, cultural relevance, and overall quality, following the rules and guidelines defined for the target locale in the `rules` directory. | ||
| The evaluator checks for accuracy, cultural relevance, and overall quality, following the rules and guidelines defined for the target locale in the `rules` directory. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ One evaluator assignment: Avoid maintaining another copy of the same review step: the ordered workflow and persona fallback already assign evaluator review after translation. The locale-specific review duties remain here. Commit |
||
|
|
||
| The evaluator scores the localized document against the locale's **Evaluator Scoring Rubric** (defined in the locale's `rules/<locale>.md`). The rubric uses two tiers: **Tier A** hard-fail criteria that must score 5, and **Tier B** graded criteria (1–5) that must score 4 or 5. A document passes only when **every applicable Tier A criterion scores 5 and every applicable Tier B criterion scores ≥ 4**. If anything falls short, return the document to the translator with specific notes and re-run the translate → evaluate loop until it passes, escalating to a human after the rubric's iteration cap. | ||
| The evaluator scores the localized document against the locale's **Evaluator Scoring Rubric** (defined in the locale's `rules/<locale>.md`). If anything falls short, return the document to the translator with specific notes and re-run the translate → evaluate loop until it passes, escalating to a human after the rubric's iteration cap. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Rubric-owned thresholds: Avoid maintaining a second set of score thresholds: the mandatory Spanish, Japanese, Korean, Portuguese, and Chinese rubrics already define both the tier thresholds and the all-applicable-criteria gate. The rubric invocation and feedback, retry, and human-escalation instructions remain. Commit |
||
|
|
||
| ## DOs and DON'Ts | ||
|
|
||
| - **Do** perform localization only for the target locales defined in the `rules` directory (one `<locale>.md` per supported locale). Do not localize into unsupported locales. | ||
| - **Do** preserve Markdown structure, code, external link/URL targets, and frontmatter keys exactly (see *Markdown and formatting preservation*). | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Complete formatting guidance: Avoid maintaining an abbreviated copy of preservation duties without their qualifications. The formatting section already requires Markdown, code, URL, and frontmatter-key preservation while retaining the frontmatter-value and explanatory-comment exceptions. Commit |
||
| - **Do** let heading anchors follow the localized heading text, and update same-document anchor links to match the new slugs so they keep resolving (see *Markdown and formatting preservation*). | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 One heading-link rule: Avoid maintaining the same heading-link duty in two places. The complete heading-anchor instructions already require localized-heading link updates and preserve the exception for non-localized files and external targets. Commit |
||
| - **Do** point image and asset paths at the original assets (rewriting the relative path as needed so it resolves from `localizations/<locale>/`), unless a corresponding localized asset exists (see *Markdown and formatting preservation*). | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Directory-aware asset guidance: Avoid maintaining an abbreviated asset-path rule alongside its complete instructions. The asset guidance and examples already account for the localized document's actual directory, allow corresponding localized assets, and require the target file to exist. Commit |
||
| - **Do** mirror the source directory layout under `localizations/<locale>/`. | ||
| - **Don't** treat files under `localizations/` as source input. | ||
| - **Don't** reorder or restructure content; keep headings and their order stable. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ One translator assignment: Avoid maintaining a second invocation of the same role: the ordered translation workflow and persona fallback already assign this step. Naming the translator directly keeps the locale-rule duty clear after removing its duplicate antecedent. Commit