Conversation
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@copilot I observe a failure in the net-new workflow for this PR: https://github.com/github/copilot-sdk/actions/runs/35281333643/job/105404197689?pr=2715 Please examine the workflow output, resolve the issue, and push the commits to the topic branch. I will approve the workflow. |
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Root cause: |
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟡 Changes recommended
Host validation currently treats any unknown non-glibc Linux host as musl, potentially producing mislabeled artifacts.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Java linuxmusl-x64 packaging, testing, publication, and documentation support.
Changes:
- Adds Maven profiles and native-host validation.
- Adds Alpine-based CI and publication workflows.
- Updates publication checks and documentation.
File summaries
| File | Description |
|---|---|
java/sdk/pom.xml |
Selects the musl runtime dependency. |
java/copilot-native/pom.xml |
Builds and attaches the musl classifier. |
java/copilot-native/scripts/validate-native-host.mjs |
Validates musl hosts. |
java/copilot-native/scripts/validate-native-host.test.mjs |
Tests host validation. |
java/copilot-native/scripts/fetch-native.test.mjs |
Covers musl artifact staging. |
java/copilot-native/scripts/validate-native-artifact.test.mjs |
Extends publication fixtures. |
java/copilot-native/scripts/validate-local-publication.mjs |
Requires the musl classifier. |
.github/workflows/java-sdk-tests.yml |
Adds Alpine tests and publication assembly. |
.github/workflows/java-publish-snapshot.yml |
Publishes musl snapshots. |
.github/workflows/java-publish-maven.yml |
Publishes musl releases. |
java/README.md |
Documents musl usage and building. |
java/docs/adr/adr-007-native-bundling-strategy.md |
Records musl publication support. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 1
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (host.glibcVersionRuntime) { | ||
| throw new Error( | ||
| `Native ${classifier} packaging requires musl; detected glibc ${host.glibcVersionRuntime}`, | ||
| ); | ||
| } | ||
| return `Validated native build host: ${classifier} (musl)`; |
|
@edburns Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
That run (35281333643) was on The latest run on I also pushed |
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
The job log confirmed the missing |
SDK Consistency ReviewI reviewed the changed files in this PR against the cross-SDK consistency criteria. Files changed:
Finding: No cross-SDK consistency issues. This PR adds a new This is Java-specific native-binary packaging infrastructure (analogous to platform-specific native artifact distribution), not an SDK feature/API change that needs to be mirrored in other languages. No inconsistency to flag.
|
Adds Java SDK packaging, CI coverage, and publication support for the
linuxmusl-x64native runtime.Packaging
linuxmusl-x64classifier.CI
linuxmusl-x64coverage to the Java in-process test matrix.Publishing
Documentation
linuxmusl-x64#2714