Skip to content

Add support for Java on darwin-x64 - #2701

Merged
edburns merged 3 commits into
mainfrom
edburns/java-add-darwin-x64
Sep 16, 2026
Merged

edburns merged 3 commits into
mainfrom
edburns/java-add-darwin-x64

Conversation

@edburns

@edburns edburns commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2428 . See the issue for details.

Copilot AI and others added 2 commits September 16, 2026 15:48
* Initial plan

* Add Java darwin-x64 native support

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 16, 2026 22:55
@edburns
edburns requested a review from a team as a code owner September 16, 2026 22:55
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Release workflows omit the new classifier, and attempt-scoped test artifacts break partial assembly reruns.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced (auto)
Findings: 1 High severity

Note

Copilot is running an experiment and ran this review at Balanced.

Open (1)
What changed in this PR

Adds Java in-process runtime packaging and testing for Intel macOS (darwin-x64).

Changes:

  • Adds Maven packaging and classifier attachment profiles.
  • Extends host validation and publication tests.
  • Adds Intel macOS CI coverage and documentation.
File Description
.github/​workflows/​java-sdk-tests.yml Adds Intel macOS testing and publication validation.
java/​sdk/​pom.xml Selects darwin-x64 on Intel macOS.
java/​copilot-native/​pom.xml Packages and attaches the native classifier.
java/​copilot-native/​scripts/​validate-native-host.mjs Validates Intel macOS hosts.
java/​copilot-native/​scripts/​validate-native-host.test.mjs Tests host validation.
java/​copilot-native/​scripts/​validate-native-artifact.test.mjs Tests classifier artifacts.
java/​copilot-native/​scripts/​validate-local-publication.mjs Requires the classifier in publications.
java/​copilot-native/​scripts/​fetch-native.test.mjs Covers native fetching.
java/​README.md Documents Intel macOS support.
java/​docs/​adr/​adr-007-native-bundling-strategy.md Updates platform and publication scope.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/java-sdk-tests.yml
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9f79eaea-d0bb-4e69-9d32-499a9c186788
@github-actions

Copy link
Copy Markdown
Contributor

SDK Consistency Review

This PR adds a darwin-x64 (macOS Intel) native classifier to the Java SDK's native-library bundling/publishing pipeline. All changed files are confined to Java-specific build and CI infrastructure:

  • .github/workflows/java-publish-maven.yml, .github/workflows/java-publish-snapshot.yml — new build-darwin-x64-classifier / java-native-publication-darwin-x64 jobs
  • java/sdk/pom.xml — new native-darwin-x64 Maven profile/activation
  • java/copilot-native/pom.xml and its scripts/*.mjs — classifier list, host validation, and artifact/publication checks extended to include darwin-x64
  • java/README.md, java/docs/adr/adr-007-native-bundling-strategy.md — docs updated to mention the new classifier

No public SDK API surface is touched — nothing under java/sdk/src/main/java/, nodejs/src/, python/copilot/, go/, dotnet/src/, or rust/src/ is modified. The change is purely about which native binary variants get packaged/published for the Java SDK's JNA-based native loader (per ADR-007), a mechanism unique to Java's packaging model (OS/arch Maven classifiers). The other language SDKs don't use this classifier-based native bundling approach, so there's no equivalent feature to add or align there.

Conclusion: No cross-SDK consistency issues. This is an internal, Java-only build/packaging enhancement (adding a supported platform) and does not require changes in other language SDKs.

Generated by SDK Consistency Review Agent for #2701 · copilot · sonnet50 · 26.2 AIC · ⌖ 12.1 AIC · ⊞ 8.3K ·

@edburns
edburns merged commit 5ea60a6 into main Sep 16, 2026
48 checks passed
@edburns
edburns deleted the edburns/java-add-darwin-x64 branch September 16, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Add support for darwin-x64

3 participants