Go: un-deprecate ParenExpr - #22650
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The compatibility fix is correct; only a minor documentation grammar issue remains.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Restores ParenExpr for compatibility with older Go databases while documenting that newer extractors omit it.
Changes:
- Removes the
deprecatedmodifier fromParenExpr. - Removes the obsolete deprecation change note.
| File | Description |
|---|---|
go/ql/lib/semmle/go/Expr.qll |
Restores and documents ParenExpr. |
go/ql/lib/change-notes/2026-08-13-cfg.md |
Removes the deprecation announcement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix typo in comment regarding ParenExpr deprecation. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
geoffw0
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is failing the "Go Compile Queries" CI check because it introduces a use of the deprecated class
ParenExpr. Although that class is deprecated, and we no longer create any instances of it with newer versions of the extractor, there wasn't actually a dbscheme change or any upgrade script to removeParenExprfrom databases. The solution is to un-deprecate that class (but keep a note in the QLDoc that it isn't being extracted any more), so that it can still be used without causing CI failure. In a year's time, when databases containingParenExprare going to be a lot less common, we can deprecate that class, change its definition to be empty, remove all references to it and remove it from the dbscheme.