Extract Swift super keywords - #22640
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused mapping change is consistently covered by corpus and control-flow expectations.
Review effort: Balanced
Findings: None
What changed in this PR
Preserves Swift super keywords so SuperExpr values render correctly.
Changes:
- Maps
superKeywordinto unifiedsuper_exprnodes. - Adds corpus coverage and updates generated expectations.
| File | Description |
|---|---|
| unified/ql/test/library-tests/controlflow/basicblock-slices.expected | Updates expected super rendering. |
| unified/extractor/tests/corpus/swift/expressions/super-expression.swift | Adds property and method access cases. |
| unified/extractor/tests/corpus/swift/expressions/super-expression.output | Records generated AST expectations. |
| unified/extractor/src/languages/swift/swift.rs | Extracts the super keyword token. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Sep 22, 2026
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
LGTM. FYI the underlying bug is tracked here https://github.com/github/codeql-team/issues/4882 but we can merge this to unblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that
SuperExprs have a propertoString.