Repository navigation
Go: Fix getType on ImplicitVarArgsSlice - #16457
Merged
Merged
Conversation
It was not defined for built-in functions or for functions called via a function variable.
smowton
previously approved these changes
May 8, 2024
smowton
left a comment
smowton
left a comment
Contributor
There was a problem hiding this comment.
Conditional on testing, lgtm
Contributor
Author
|
DCA is blissfully uneventful. |
Contributor
Author
|
@smowton Please re-approve when you have a minute. I added a change note and it dismissed your approval. |
smowton
approved these changes
May 8, 2024
This was referenced May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not defined for built-in functions or for functions called via a function variable.
I've pulled this commit out of #16413 so that it can be reviewed and performance-tested in isolation. I don't think it needs a test because it is tested by that PR, and by all the tests for data flow through variadic arguments.