This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Add interactive password input - #40
Merged
Merged
Conversation
shlomi-noach
suggested changes
Aug 27, 2017
shlomi-noach
left a comment
shlomi-noach
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Looking good. Request for argument name change.
| help := flag.Bool("help", false, "Display usage") | ||
| user := flag.String("u", osUser, "MySQL username") | ||
| password := flag.String("p", "", "MySQL password") | ||
| askPassword := flag.Bool("P", false, "Ask mySQL password") |
Contributor
There was a problem hiding this comment.
Can we please change argument to ask-pass? This will make it compatible with gh-ost and with Percona Toolkit.
shlomi-noach
approved these changes
Aug 27, 2017
Contributor
|
Long overdue opportunity to set up TravisCI for this repo, adding public visibility into CI |
Contributor
|
Added |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive input password can be very convenient and more secure:)