Repository navigation
Fail with an error message when the destination cannot write the requested library or performance - #296
Merged
git-moss merged 2 commits intoAug 1, 2026
Conversation
…performance Creating a library or a performance is an empty default operation for a destination which does not support it, so everything that was detected got collected and then silently dropped: the run reported "Finished" and left an empty output folder. Converting 175 Elektron Tonverk presets to Waldorf QPAT with '-l MyLib' wrote nothing, as did Kontakt multis to QPAT with '-t performance'. Both now fall back to what the destination can write - one preset per source, and the instruments of a performance as presets - and log which of the two happened. Destinations which do support libraries or performances are untouched: the same Deluge folder to a DecentSampler library still writes one dslibrary with identical contents, and to TX16Wx performances the same 2170 files. The user interface keeps offering only the output types of the destination, so this only becomes visible on the command line, which accepts '-l' and '-t performance' for every destination.
Owner
|
Shouldn't that simply fail with an error message? |
The destination capabilities are known before anything runs, so the command line now rejects '-l' and '-t performance' for a destination which cannot write them, before the detection starts. The single-preset fallback and its log lines are gone; ConverterBackend is back to stock.
douglas-carmichael
changed the title
Contributor
Author
|
Agreed - |
git-moss
pushed a commit
that referenced
this pull request
Sep 25, 2026
…ested library or performance (#296) * Write single presets when the destination cannot hold a library or a performance Creating a library or a performance is an empty default operation for a destination which does not support it, so everything that was detected got collected and then silently dropped: the run reported "Finished" and left an empty output folder. Converting 175 Elektron Tonverk presets to Waldorf QPAT with '-l MyLib' wrote nothing, as did Kontakt multis to QPAT with '-t performance'. Both now fall back to what the destination can write - one preset per source, and the instruments of a performance as presets - and log which of the two happened. Destinations which do support libraries or performances are untouched: the same Deluge folder to a DecentSampler library still writes one dslibrary with identical contents, and to TX16Wx performances the same 2170 files. The user interface keeps offering only the output types of the destination, so this only becomes visible on the command line, which accepts '-l' and '-t performance' for every destination. * Fail with an error message instead of falling back to single presets The destination capabilities are known before anything runs, so the command line now rejects '-l' and '-t performance' for a destination which cannot write them, before the detection starts. The single-preset fallback and its log lines are gone; ConverterBackend is back to stock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a library or a performance is an empty default operation for a destination which does not support it, so everything that was detected got collected and then silently dropped: the run reported "Finished." and left an empty output folder. Converting 175 Elektron Tonverk presets to Waldorf QPAT with
-l MyLibwrote nothing, as did Kontakt multis to QPAT with-t performance. The command line accepts-land-t performancefor every destination, so this is easy to hit.The command line now fails with an error message before the detection starts (updated after review - the first version fell back to writing single presets):
SFZ cannot write a library which contains several presets. Remove the option '-l' or choose a destination format which supports libraries.SFZ cannot write performances. Remove the option '-t performance' or choose a destination format which supports performances.The user interface is not affected, since it only offers the output types which the destination supports. Destinations which do support libraries or performances are untouched: the same source to a Synclavier V library still writes one synx file, and a plain preset conversion is unchanged.