Repository navigation
Waldorf Quantum/Iridium: do not cut off the preset name at the bank - #294
Merged
git-moss merged 1 commit intoJul 31, 2026
Merged
Conversation
A preset which comes from a bank carries the bank in front of its name. The device has a field of its own for the bank, so the name is written without it - except when an explicit Bank is configured, which replaces the bank of the source: the name then keeps it, so that it is not lost entirely. The name field of the device holds 32 characters and everything beyond that is cut off, which is exactly the part that tells the presets of one bank apart. Two presets of an E-mu library CD, 'Full Arco String - Arco Strings Lo' and '... Hi', both ended up as 'Full Arco String - Arco Strings' and were indistinguishable in the browser of the device. The bank of the source is now dropped from the name as soon as the qualified name does not fit, which is logged, and the file name carries it as before. A name which fits is written unchanged.
git-moss
added a commit
that referenced
this pull request
Jul 31, 2026
…layed name (stacked on #294) (#295) * Waldorf Quantum/Iridium: do not cut off the preset name at the bank A preset which comes from a bank carries the bank in front of its name. The device has a field of its own for the bank, so the name is written without it - except when an explicit Bank is configured, which replaces the bank of the source: the name then keeps it, so that it is not lost entirely. The name field of the device holds 32 characters and everything beyond that is cut off, which is exactly the part that tells the presets of one bank apart. Two presets of an E-mu library CD, 'Full Arco String - Arco Strings Lo' and '... Hi', both ended up as 'Full Arco String - Arco Strings' and were indistinguishable in the browser of the device. The bank of the source is now dropped from the name as soon as the qualified name does not fit, which is logged, and the file name carries it as before. A name which fits is written unchanged. * Waldorf Quantum/Iridium: option to shorten the file names to the displayed name The file name of a written preset keeps the full name of the source, which for a preset of a bank is the bank plus the preset ('05000-Full Arco String - Arco Strings Lo.qpat', 45 characters). That is what tells the files apart in a file browser on the computer, but more than the import screen of the device shows: measured on the display of an Iridium MK2, the file list of the import screen displays about 43 characters and cuts off the rest - exactly the end that tells the presets apart. The new option names the file after the preset name which the device displays - the same name which is written into the name field - and keeps the whole file name, including the import number prefix and the '.qpat' ending, within a budget of 40 characters. The example becomes '05000-Arco Strings Lo.qpat'. The name field is not affected: 'Full Arco String - Swirly Arcos' stays complete in the preset while its file becomes '05002-Full Arco String - Swirly Arc.qpat'. The sample folder follows the same name, so file and folder keep matching. Disabled by default. The name for the name field is now created once in createPreset and passed to the writing method, since both uses need it. --------- Co-authored-by: Jürgen Moßgraber <juergen.mossgraber@googlemail.com>
git-moss
pushed a commit
that referenced
this pull request
Sep 25, 2026
…294) A preset which comes from a bank carries the bank in front of its name. The device has a field of its own for the bank, so the name is written without it - except when an explicit Bank is configured, which replaces the bank of the source: the name then keeps it, so that it is not lost entirely. The name field of the device holds 32 characters and everything beyond that is cut off, which is exactly the part that tells the presets of one bank apart. Two presets of an E-mu library CD, 'Full Arco String - Arco Strings Lo' and '... Hi', both ended up as 'Full Arco String - Arco Strings' and were indistinguishable in the browser of the device. The bank of the source is now dropped from the name as soon as the qualified name does not fit, which is logged, and the file name carries it as before. A name which fits is written unchanged.
git-moss
added a commit
that referenced
this pull request
Sep 25, 2026
…layed name (stacked on #294) (#295) * Waldorf Quantum/Iridium: do not cut off the preset name at the bank A preset which comes from a bank carries the bank in front of its name. The device has a field of its own for the bank, so the name is written without it - except when an explicit Bank is configured, which replaces the bank of the source: the name then keeps it, so that it is not lost entirely. The name field of the device holds 32 characters and everything beyond that is cut off, which is exactly the part that tells the presets of one bank apart. Two presets of an E-mu library CD, 'Full Arco String - Arco Strings Lo' and '... Hi', both ended up as 'Full Arco String - Arco Strings' and were indistinguishable in the browser of the device. The bank of the source is now dropped from the name as soon as the qualified name does not fit, which is logged, and the file name carries it as before. A name which fits is written unchanged. * Waldorf Quantum/Iridium: option to shorten the file names to the displayed name The file name of a written preset keeps the full name of the source, which for a preset of a bank is the bank plus the preset ('05000-Full Arco String - Arco Strings Lo.qpat', 45 characters). That is what tells the files apart in a file browser on the computer, but more than the import screen of the device shows: measured on the display of an Iridium MK2, the file list of the import screen displays about 43 characters and cuts off the rest - exactly the end that tells the presets apart. The new option names the file after the preset name which the device displays - the same name which is written into the name field - and keeps the whole file name, including the import number prefix and the '.qpat' ending, within a budget of 40 characters. The example becomes '05000-Arco Strings Lo.qpat'. The name field is not affected: 'Full Arco String - Swirly Arcos' stays complete in the preset while its file becomes '05002-Full Arco String - Swirly Arc.qpat'. The sample folder follows the same name, so file and folder keep matching. Disabled by default. The name for the name field is now created once in createPreset and passed to the writing method, since both uses need it. --------- Co-authored-by: Jürgen Moßgraber <juergen.mossgraber@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an explicit Bank is configured, the preset name keeps the bank of the source, so that it is not lost entirely. But the name field of the device holds 32 characters and everything beyond that is cut off - which is exactly the part that tells the presets of one bank apart. Converting an E-mu library CD with Bank set, 'Full Arco String - Arco Strings Lo' and 'Full Arco String - Arco Strings Hi' both ended up as 'Full Arco String - Arco Strings ' and were indistinguishable in the browser of the device.
The bank of the source is now dropped from the name as soon as the qualified name does not fit the field, which is logged; the file name carries the full name as before, so nothing is lost on the computer. A qualified name which fits - e.g. 'Full Arco String - Dull Arcos', 29 characters - is written unchanged.
Verified by reading the written headers back: with Bank set, the two colliding presets now store 'Arco Strings Lo' and 'Arco Strings Hi' with the bank in the Bank field; without Bank the output is unchanged.