Repository navigation
Show the contents of every source format, not only of banks and disk images - #293
Merged
Merged
Conversation
…images The Contents dialog was limited to the formats where one file holds several presets. It is just as useful for a folder of files which each hold one preset - e.g. Elektron Tonverk or Synthstrom Deluge presets - since it lists the preset names stored inside of the files, their zones, key ranges and categories, and allows to listen to them before converting. The list of multi-preset formats is therefore gone and the button is shown for every source format. The tree grew a level for this: the folders below the source folder come first, then the file - but only if it holds more than the one preset, otherwise a folder of presets would be doubled by a folder per file - then the containers inside of the file. The folders were part of the container path before and therefore ended up *below* the file of a preset instead of above it. A preset which is named differently than its file shows the file name as well, so that it can still be told apart. A format whose preset is not a file at all - the sample files of a folder become one multi-sample - reports its folder as the source file. Selecting such a preset read nothing, since the detection ran the folder through the file detection which filters by file ending. Folders are now detected as folders.
git-moss
added a commit
that referenced
this pull request
Sep 25, 2026
…images (#293) The Contents dialog was limited to the formats where one file holds several presets. It is just as useful for a folder of files which each hold one preset - e.g. Elektron Tonverk or Synthstrom Deluge presets - since it lists the preset names stored inside of the files, their zones, key ranges and categories, and allows to listen to them before converting. The list of multi-preset formats is therefore gone and the button is shown for every source format. The tree grew a level for this: the folders below the source folder come first, then the file - but only if it holds more than the one preset, otherwise a folder of presets would be doubled by a folder per file - then the containers inside of the file. The folders were part of the container path before and therefore ended up *below* the file of a preset instead of above it. A preset which is named differently than its file shows the file name as well, so that it can still be told apart. A format whose preset is not a file at all - the sample files of a folder become one multi-sample - reports its folder as the source file. Selecting such a preset read nothing, since the detection ran the folder through the file detection which filters by file ending. Folders are now detected as folders. Co-authored-by: Jürgen Moßgraber <juergen.mossgraber@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Contents... dialog is just as useful for a folder of files which each hold one preset as it is for a bank: it lists the preset names stored inside the files - which are not necessarily the names of the files - with their zones, key ranges and categories, everything can be auditioned before converting, and the conversion afterwards only reads the files of the ticked presets. The hard-coded list of multi-preset formats is therefore gone and the button is shown for every source format.
The tree grew a level for this: the folders below the source folder come first, then the file - but only when it holds more than the one preset, otherwise a folder of presets would be doubled by a one-child folder per file - then the containers inside of the file. The folders were part of the container path before and rendered below the file of a preset instead of above it. A preset which is named differently than its file additionally shows the file name in its row, so the two can still be matched.
This surfaced a real defect: the Sample Files format reports a folder as the source of a multi-sample, so a selection made in the Contents dialog converted nothing - the conversion ran the folder through the file detection, which filters by file ending, and finished with an empty output.
AbstractDetectornow detects a folder-shaped source as a folder, which also makes the audition work for it.Measured with the harness reproducing the dialog's tree plus a real conversion of the selection:
Re-reading every entry through the audition path and comparing with the contents run: 175/175 Tonverk, 46/46 Deluge, 2/2 Sample Files - 0 mismatches, 0 unreadable.