fix: restore lines background with configurable color - #502
Open
oosuhada wants to merge 1 commit into
Open
Conversation
oosuhada
force-pushed
the
fix/issue-492-lines-background
branch
from
August 28, 2026 08:44
3044c33 to
7472902
Compare
Member
|
์๋
ํ์ธ์ @oosuhada ๋ ์ปค๋ฐ๊ณผ ์ถฉ๋์ ํด๊ฒฐํด์ฃผ์ค ์ ์์ผ์ ๊ฐ์? |
oosuhada
force-pushed
the
fix/issue-492-lines-background
branch
from
August 30, 2026 01:16
7472902 to
36e4970
Compare
Author
|
์๋ ํ์ธ์ @devxb ๋, ํ์ธ ๊ฐ์ฌํฉ๋๋ค. fork ์ชฝ commit history๊ฐ upstream๊ณผ ๋ค๋ฅด๊ฒ ์ฐ๊ฒฐ๋์ด unrelated commits๊ฐ ํจ๊ป ํฌํจ๋ ์ํ์์ต๋๋ค. upstream/main ๊ธฐ์ค์ผ๋ก history๋ฅผ ๋ค์ ์ ๋ฆฌํ๊ณ 1๊ฐ์ commit์ผ๋ก ์ ๋ฆฌํ์ต๋๋ค. ํ์ฌ conflict ์์ด ๋ณ๊ฒฝ์ฌํญ๋ #492 ๊ด๋ จ 5๊ฐ ํ์ผ๋ง ๋จ์ ์์ต๋๋ค. ๋ค์ ํ๋ฒ ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
์์ฝ
/lines/{username}endpoint์ ๊ธฐ๋ณธ ๋ฐฐ๊ฒฝ์ ํฐ์์ผ๋ก ๋ณต์ํ์ต๋๋ค.background-colorquery parameter๋ฅผ ์ถ๊ฐํด ๋คํฌ๋ชจ๋๋ ๋ค๋ฅธ ๋ฐฐ๊ฒฝ์์๋ ์ํ๋ ์์์ ์ง์ ์ง์ ํ ์ ์๋๋ก ํ์ต๋๋ค./lines/{username}โwhite/lines/{username}?background-color=0d1117/lines/{username}?background-color=transparent#0d1117ํํ๋ ์ง์ํ๋ฉฐ URL์์๋#๋ฅผ%23์ผ๋ก ์ธ์ฝ๋ฉํ ์ ์์ต๋๋ค.white,transparent, 3/4/6/8์๋ฆฌ hex ์์๋ง ํ์ฉํฉ๋๋ค./lines/{username}/only-petsendpoint๋ ๊ธฐ์กด์ ํฌ๋ช ๋ฐฐ๊ฒฝ ๋์์ ์ ์งํฉ๋๋ค.width,height,viewBox๋ฅผ ๋ค์ ์ถ๊ฐํ์ง ์์ ๊ธฐ์กด ๋ฐ์ํ SVG ํฌ๊ธฐ ์กฐ์ ๋์๋ ์ ์งํฉ๋๋ค.ํ ์คํธ
./gradlew test --tests 'org.gitanimals.render.domain.UserTest' --console=plaingit diff --check1200x150viewport ์ ์ฒด๋ฅผ ์ฑ์ฐ๋ ๊ฒ๋ headless Chrome์์ ํ์ธํ์ต๋๋ค.Summary
/lines/{username}endpoint so GitHub page colors do not show throughbackground-colorquery parameter so users can choose a background that fits dark mode or other surfaces/lines/{username}โwhite/lines/{username}?background-color=0d1117/lines/{username}?background-color=transparent#0d1117as well;#can be URL-encoded as%23white,transparent, or 3/4/6/8 digit hex colors to avoid SVG attribute injection/lines/{username}/only-petsendpointwidth,height, orviewBoxattributesTest
./gradlew test --tests 'org.gitanimals.render.domain.UserTest' --console=plaingit diff --check1200x150viewportFixes #492