Skip to content

convert : use f32 outtype for bf16 tensors - #6106

Merged
ggerganov merged 1 commit into
ggml-org:masterfrom
Artefact2:artefact-convert-bf16-as-f32
Mar 18, 2024
Merged

ggerganov merged 1 commit into
ggml-org:masterfrom
Artefact2:artefact-convert-bf16-as-f32

Conversation

@Artefact2

@Artefact2 Artefact2 commented Mar 16, 2024 •

Copy link
Copy Markdown
Contributor

The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion. Change the outtype to f32 to default to a lossless conversion.

This restores original intended behaviour of #1309.

The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
@cebtenzzre

Copy link
Copy Markdown
Collaborator

This was originally changed in commit 3839704, which was part of #2635 which was merged into #2398.

@ggerganov
ggerganov merged commit 3a6efdd into ggml-org:master Mar 18, 2024
@cebtenzzre
cebtenzzre removed the request for review from ivanstepanovftw March 18, 2024 16:29
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
The old behaviour is to use f16, but bf16 to f16 is not a lossless conversion.
Change the outtype to f32 to default to a lossless conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants