Repository navigation
feat(search-events): Require validation before search and agent repair - #1113
Merged
Merged
Conversation
Block search_events until GET /events/validate/ passes. When validation fails with an embedded agent configured, run up to three repair attempts before returning formatted validation errors. Without an agent provider, reject invalid searches immediately. Keep datasetAttributes as discovery-only, add validation telemetry spans, and cover repair success, repaired /events/ params, and retry limits in tests. Co-Authored-By: Composer <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df84e43. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Preserve prior fields when repair returns an empty array, merge repaired environment into the executed search query, and clear agent API keys with empty strings so the no-agent rejection path is exercised in tests. Refs GH-1113 Co-Authored-By: Composer <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block search_events until GET /events/validate/ passes. When validation fails with an embedded agent configured, run up to three repair attempts before returning formatted validation errors. Without an agent provider, reject invalid searches immediately.
Keep datasetAttributes as discovery-only, add validation telemetry spans, and cover repair success, repaired /events/ params, and retry limits in tests.