Skip to content

fix(breadcrumbs): breadcrumbs ui improvement and minor bug fix - #194

Merged
Lms24 merged 4 commits into
getsentry:mainfrom
Shubhdeep12:fix/breadcrumbs-improvement
Dec 1, 2023
Merged

Lms24 merged 4 commits into
getsentry:mainfrom
Shubhdeep12:fix/breadcrumbs-improvement

Conversation

@Shubhdeep12

Copy link
Copy Markdown
Contributor

image

  • some UI improvement
  • bug fix - if statement for checking empty screen in breadcrumbs was missing a condition

Fixes: #178

@vercel

vercel Bot commented Dec 1, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 3:00pm

@codecov

codecov Bot commented Dec 1, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (68ec4a9) 32.88% compared to head (ee979ed) 32.57%.
Report is 3 commits behind head on main.

❗ Current head ee979ed differs from pull request most recent head a5ed657. Consider uploading reports for the commit a5ed657 to get more accurate results

Files Patch % Lines
...ntegrations/sentry/components/EventBreadcrumbs.tsx 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   32.88%   32.57%   -0.32%     
==========================================
  Files          37       37              
  Lines        1785     1793       +8     
  Branches       71       68       -3     
==========================================
- Hits          587      584       -3     
- Misses       1198     1209      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this already looks much better! I have one more suggestion for a quick improvement:

Can we display the breadcrumb category above the timestamp and make it visually more distinctive? E.g. make the category bolder and a bit larger (or the time smaller). I'll leave the details up to you ;)

Comment thread packages/overlay/src/integrations/sentry/components/EventBreadcrumbs.tsx Outdated
…crumbs.tsx

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@Shubhdeep12

Copy link
Copy Markdown
Contributor Author

Thanks! I think this already looks much better! I have one more suggestion for a quick improvement:

Can we display the breadcrumb category above the timestamp and make it visually more distinctive? E.g. make the category bolder and a bit larger (or the time smaller). I'll leave the details up to you ;)

Sure.

@Shubhdeep12

Copy link
Copy Markdown
Contributor Author

image
cc @Lms24

@Shubhdeep12
Shubhdeep12 requested a review from Lms24 December 1, 2023 15:02

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Lms24
Lms24 merged commit 80d27c5 into getsentry:main Dec 1, 2023
@Shubhdeep12
Shubhdeep12 deleted the fix/breadcrumbs-improvement branch December 4, 2023 13:17

This branch was successfully deployed

1 active deployment
Preview — a5ed657a Deployed Dec 1, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breadcrumbs need improved

2 participants