Repository navigation
POC for synchronous error rendering #179
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,21 @@ | ||
| import * as Sentry from '@sentry/astro'; | ||
| import { getCurrentHub, type Event } from '@sentry/astro'; | ||
|
|
||
| Sentry.init({ | ||
| debug: true, | ||
| integrations: [new Sentry.BrowserTracing(), new Sentry.Replay()], | ||
| tracesSampleRate: 1.0, | ||
| }); | ||
|
|
||
| if (process.env.NODE_ENV === 'development') { | ||
| import('@spotlightjs/astro').then(Spotlight => { | ||
| const client = getCurrentHub().getClient(); | ||
| if (client && client.on) { | ||
| client.on('beforeSendEvent', (event: Event) => { | ||
| if (event.exception && event.exception.values && event.exception.values[0].mechanism?.handled === false) { | ||
| Spotlight.trigger('sentry:showError', { eventId: event.event_id, event }); | ||
| } | ||
| }); | ||
| } | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,46 @@ | ||
| --- | ||
| interface Props { | ||
| title: string; | ||
| } | ||
|
|
||
| const { title } = Astro.props; | ||
| --- | ||
|
|
||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="description" content="Astro description" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <link rel="icon" type="image/svg+xml" href="/favicon.svg" /> | ||
| <meta name="generator" content={Astro.generator} /> | ||
| <title>{title}</title> | ||
| </head> | ||
| <body> | ||
| <slot /> | ||
| </body> | ||
| </html> | ||
| <style is:global> | ||
| :root { | ||
| --accent: 136, 58, 234; | ||
| --accent-light: 224, 204, 250; | ||
| --accent-dark: 49, 10, 101; | ||
| --accent-gradient: linear-gradient(45deg, rgb(var(--accent)), rgb(var(--accent-light)) 30%, white 60%); | ||
| } | ||
| html { | ||
| font-family: system-ui, sans-serif; | ||
| background: #13151a; | ||
| background-size: 224px; | ||
| } | ||
| code { | ||
| font-family: | ||
| Menlo, | ||
| Monaco, | ||
| Lucida Console, | ||
| Liberation Mono, | ||
| DejaVu Sans Mono, | ||
| Bitstream Vera Sans Mono, | ||
| Courier New, | ||
| monospace; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we could actually add localStorage settings into spotlight and make this a default behavior for any unhandled error coming in too.
can also keep this behavior (i think we NEED it) and continue w/ a setting to toggle it