Skip to content

ref: fix types for create_or_update to match the requirements of BaseManager - #73596

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-typing-create-or-update
Jul 1, 2024
Merged

asottile-sentry merged 1 commit into
masterfrom
asottile-typing-create-or-update

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

fixes this when managers are type checked:

src/sentry/db/models/manager/base.py:481: error: Argument 1 to "create_or_update" has incompatible type "type[M]"; expected "type[BaseModel]"  [arg-type]

@asottile-sentry
asottile-sentry requested review from a team July 1, 2024 18:26
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 1, 2024
@asottile-sentry
asottile-sentry enabled auto-merge (squash) July 1, 2024 18:27
@asottile-sentry
asottile-sentry merged commit 646521b into master Jul 1, 2024
@asottile-sentry
asottile-sentry deleted the asottile-typing-create-or-update branch July 1, 2024 18:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2024

This branch was successfully deployed

1 active deployment
Preview — 29db24a1 Deployed Jul 1, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants