Skip to content

ref: fix passing slug=None to HC slug check - #73121

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-fix-passing-none-to-slug-check
Jun 21, 2024
Merged

ref: fix passing slug=None to HC slug check#73121
asottile-sentry merged 1 commit into
masterfrom
asottile-fix-passing-none-to-slug-check

Conversation

@asottile-sentry

@asottile-sentry asottile-sentry commented Jun 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

this currently produces an INFO log on every logged out request

16:38:59 server  | 16:38:59 [INFO] sentry.services.hybrid_cloud: Organization by slug [None] not found

this fixes these two type errors as well:

src/sentry/web/frontend/auth_login.py:509: error: Argument "slug" to "check_organization_by_slug" of "OrganizationService" has incompatible type "str | None"; expected "str"  [arg-type]
src/sentry/web/frontend/auth_login.py:568: error: Argument "slug" to "check_organization_by_slug" of "OrganizationService" has incompatible type "str | None"; expected "str"  [arg-type]

@asottile-sentry
ref: fix passing slug=None to HC slug check
8afcafb 
this produces an INFO log on every logged out request
@asottile-sentry
asottile-sentry requested review from a team June 21, 2024 18:43
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 21, 2024
@joshuarli

joshuarli commented Jun 21, 2024

Copy link
Copy Markdown
Member

man, typing is good

@asottile-sentry
asottile-sentry enabled auto-merge (squash) June 21, 2024 18:46
@asottile-sentry
asottile-sentry merged commit 7281bbf into master Jun 21, 2024
@asottile-sentry
asottile-sentry deleted the asottile-fix-passing-none-to-slug-check branch June 21, 2024 19:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2024

This branch was successfully deployed

1 active deployment
Preview — 8afcafbb Deployed Jun 21, 2024 by vercel[bot]
View deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asottile-sentry @joshuarli