Skip to content

ref: add mypy plugin to fix referencing .objects through a TypeVar - #72877

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-objects-through-typevar
Jun 18, 2024
Merged

asottile-sentry merged 1 commit into
masterfrom
asottile-objects-through-typevar

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

fortunately there's enough plugin hooks that we can work around python/mypy#17395

@asottile-sentry
asottile-sentry requested a review from a team June 17, 2024 18:36
@asottile-sentry
asottile-sentry requested review from a team as code owners June 17, 2024 18:36
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2024
@asottile-sentry
asottile-sentry force-pushed the asottile-objects-through-typevar branch from bcf5ef6 to 8e3b2b2 Compare June 17, 2024 18:41
@codecov

codecov Bot commented Jun 17, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@4de2805). Learn more about missing BASE report.

❗ Current head 8e3b2b2 differs from pull request most recent head bddf533

Please upload reports for the commit bddf533 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #72877   +/-   ##
=========================================
  Coverage          ?   78.04%           
=========================================
  Files             ?     6605           
  Lines             ?   294431           
  Branches          ?    50756           
=========================================
  Hits              ?   229794           
  Misses            ?    58302           
  Partials          ?     6335           
Files Coverage Δ
src/sentry/hybridcloud/models/webhookpayload.py 100.00% <100.00%> (ø)

@asottile-sentry
asottile-sentry merged commit de3e607 into master Jun 18, 2024
@asottile-sentry
asottile-sentry deleted the asottile-objects-through-typevar branch June 18, 2024 19:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2024

This branch was successfully deployed

1 active deployment
Preview — bddf5339 Deployed Jun 18, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants