Skip to content

ref: improve typing for sentry.db.models.query - #72872

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-type-db-models-query
Jun 17, 2024
Merged

asottile-sentry merged 1 commit into
masterfrom
asottile-type-db-models-query

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

No description provided.

@asottile-sentry
asottile-sentry requested review from a team June 17, 2024 17:33
@asottile-sentry
asottile-sentry requested a review from a team as a code owner June 17, 2024 17:33
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2024
@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.05%. Comparing base (fcb6eef) to head (dfa5860).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72872      +/-   ##
==========================================
- Coverage   78.05%   78.05%   -0.01%     
==========================================
  Files        6603     6601       -2     
  Lines      294413   294384      -29     
  Branches    50756    50752       -4     
==========================================
- Hits       229793   229770      -23     
+ Misses      58285    58281       -4     
+ Partials     6335     6333       -2     
Files Coverage Δ
src/sentry/db/models/query.py 68.13% <75.00%> (+0.69%) ⬆️

... and 19 files with indirect coverage changes

@asottile-sentry
asottile-sentry merged commit 466af61 into master Jun 17, 2024
@asottile-sentry
asottile-sentry deleted the asottile-type-db-models-query branch June 17, 2024 18:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2024

This branch was successfully deployed

1 active deployment
Preview — dfa58609 Deployed Jun 17, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants