Skip to content

ref: fix a few type errors in sentry testutils - #72806

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-typing-testutils
Jun 14, 2024
Merged

asottile-sentry merged 1 commit into
masterfrom
asottile-typing-testutils

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

fixes some errors when BaseManager becomes typechecked

@asottile-sentry
asottile-sentry requested review from a team June 14, 2024 20:42
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2024
@asottile-sentry
asottile-sentry enabled auto-merge (squash) June 14, 2024 20:56
@codecov

codecov Bot commented Jun 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (f98a882) to head (cd5b716).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72806       +/-   ##
===========================================
- Coverage   88.20%   78.05%   -10.15%     
===========================================
  Files        2900     6601     +3701     
  Lines      180171   294373   +114202     
  Branches    32214    50753    +18539     
===========================================
+ Hits       158920   229778    +70858     
- Misses      15342    58352    +43010     
- Partials     5909     6243      +334     
Files Coverage Δ
src/sentry/testutils/factories.py 93.32% <100.00%> (+<0.01%) ⬆️
src/sentry/testutils/pytest/sentry.py 85.11% <100.00%> (+0.06%) ⬆️
...ntry/web/frontend/debug/debug_performance_issue.py 90.90% <100.00%> (ø)

... and 3704 files with indirect coverage changes

@asottile-sentry
asottile-sentry merged commit 48143af into master Jun 14, 2024
@asottile-sentry
asottile-sentry deleted the asottile-typing-testutils branch June 14, 2024 22:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2024

This branch was successfully deployed

1 active deployment
Preview — cd5b7167 Deployed Jun 14, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants