Skip to content

ref: remove OptionMixin - #72797

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-rm-options-mixin
Jun 14, 2024
Merged

asottile-sentry merged 1 commit into
masterfrom
asottile-rm-options-mixin

Conversation

@asottile-sentry

Copy link
Copy Markdown
Contributor

this fixes types for the various models involved

mixins aren't sound in typing unless they have an associated protocol -- and even then there aren't dependent types so this mixin couldn't possibly be typed properly. it also wasn't being used at runtime either so it was easier to just write the methods directly in the two subclasses

this fixes types for the various models involved
@asottile-sentry
asottile-sentry requested review from a team June 14, 2024 18:42
@asottile-sentry
asottile-sentry requested review from a team as code owners June 14, 2024 18:42
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2024

@JoshFerge JoshFerge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@codecov

codecov Bot commented Jun 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (eca152a) to head (c7c6374).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72797      +/-   ##
==========================================
- Coverage   78.05%   78.04%   -0.01%     
==========================================
  Files        6601     6602       +1     
  Lines      294329   294356      +27     
  Branches    50751    50746       -5     
==========================================
+ Hits       229729   229741      +12     
- Misses      58361    58376      +15     
  Partials     6239     6239              
Files Coverage Δ
src/sentry/models/options/option.py 100.00% <100.00%> (ø)
src/sentry/models/project.py 94.75% <100.00%> (+0.03%) ⬆️
...sentry/services/hybrid_cloud/organization/model.py 90.47% <100.00%> (-0.05%) ⬇️
src/sentry/services/hybrid_cloud/project/model.py 63.63% <100.00%> (-1.07%) ⬇️
src/sentry/models/organization.py 87.60% <87.50%> (-0.11%) ⬇️

... and 20 files with indirect coverage changes

@markstory markstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@asottile-sentry
asottile-sentry merged commit c136332 into master Jun 14, 2024
@asottile-sentry
asottile-sentry deleted the asottile-rm-options-mixin branch June 14, 2024 19:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2024

This branch was successfully deployed

1 active deployment
Preview — c7c6374f Deployed Jun 14, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants