Skip to content

feat: Add Spotlight - #61355

Merged
HazAT merged 18 commits into
masterfrom
feat/spotlight
Dec 11, 2023
Merged

HazAT merged 18 commits into
masterfrom
feat/spotlight

Conversation

@HazAT

@HazAT HazAT commented Dec 7, 2023

Copy link
Copy Markdown
Member

Follow-up: #60523

@HazAT
HazAT requested review from a team as code owners December 7, 2023 15:30
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 7, 2023
@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Comment thread src/sentry/utils/sdk.py
ThreadingIntegration(propagate_hub=True),
OpenAiIntegration(capture_prompts=True),
],
spotlight=settings.IS_DEV,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this get used?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean Spotlight?
Only in dev mode this option should be True

@codecov

codecov Bot commented Dec 7, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #61355 (25d7cf2) into master (7d8436d) will decrease coverage by 2.02%.
The diff coverage is n/a.

❗ Current head 25d7cf2 differs from pull request most recent head 8978da7. Consider uploading reports for the commit 8978da7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #61355      +/-   ##
==========================================
- Coverage   83.10%   81.09%   -2.02%     
==========================================
  Files        5546     5195     -351     
  Lines      237303   228310    -8993     
  Branches    38257    38285      +28     
==========================================
- Hits       197209   185145   -12064     
+ Misses      39810    37550    -2260     
- Partials      284     5615    +5331     
Files Coverage Δ
src/sentry/conf/server.py 89.47% <ø> (-1.66%) ⬇️
src/sentry/utils/sdk.py 71.17% <ø> (-9.04%) ⬇️
static/app/bootstrap/initializeSdk.tsx 0.00% <ø> (ø)

... and 1887 files with indirect coverage changes

@HazAT

HazAT commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

Need to figure out this:
#60523 (comment)

when I run locally in the branch:
yarn build-production
and
yarn tsc -p config/tsconfig.build.json
both succeed

@billyvg

billyvg commented Dec 7, 2023

Copy link
Copy Markdown
Member

@HazAT it needs to be a dep, not devDep

Comment thread static/app/bootstrap/initializeSdk.tsx Outdated
@HazAT

HazAT commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

@HazAT it needs to be a dep, not devDep

Done, thx

Comment thread package.json Outdated

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we'd not have the webpack plugin as a dep, but I think that'd require some webpack config refactoring.

@HazAT
HazAT merged commit 6c235b0 into master Dec 11, 2023
@HazAT
HazAT deleted the feat/spotlight branch December 11, 2023 08:23
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 26, 2023

This branch was successfully deployed

1 active deployment
Preview — 4cf95ffa Deployed Dec 11, 2023 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants