chore(client): Deprecate Client::sample_should_send - #1328
Open
szokeasaurusrex wants to merge 1 commit into
Open
szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
szokeasaurusrex
added this pull request to stack #1332
September 22, 2026 13:39
Deprecate `Client::sample_should_send`, as there is no reason for it to be in the public API. Replace the method with a standalone function in the `client` module.
szokeasaurusrex
force-pushed
the
szokeasuarusrex/deprecate-sample_should_send
branch
from
September 22, 2026 13:45
fa4873b to
a0364ed
Compare
szokeasaurusrex
marked this pull request as ready for review
September 22, 2026 13:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
Client::sample_should_send, as there is no reason for it to be in the public API. Replace the method with a standalone function in theclientmodule.