Skip to content

ref(launchdarkly): Remove __init__ from integration - #7041

Merged
sentrivana merged 1 commit into
major/3.0from
ivana/major/remove-launchdarkly-init
Aug 5, 2026
Merged

ref(launchdarkly): Remove __init__ from integration#7041
sentrivana merged 1 commit into
major/3.0from
ivana/major/remove-launchdarkly-init

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Description

The LaunchDarkly client is a singleton. As such, it doesn't make sense to provide a way to patch a specific client only.

This allows us to get rid of the integation __init__, which is always good: integrations are meant to be setup via setup_once.

Issues

Closes #7040

Reminders

@sentrivana
sentrivana marked this pull request as ready for review August 5, 2026 09:05
@sentrivana
sentrivana requested a review from a team as a code owner August 5, 2026 09:05
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90940 passed | ❌ 1 failed | ⏭️ 5436 skipped | Total: 96377 | Pass Rate: 94.36% | Execution Time: 334m 41s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -6836
Passed Tests 📉 -6034
Failed Tests 📈 +1
Skipped Tests 📉 -803

➕ New Tests (1)

View new tests
  • test_trace_decorator_no_trx
    • File: tests.tracing.test_decorator
    • Status: ❌ Failing

❌ Failed Tests

test_trace_decorator_no_trx

File: tests.tracing.test_decorator
Suite: py3.10-gevent
Error: AssertionError: Expected 'mock' to be called once. Called 2 times. Calls: [call('Cannot create a child span for %s. Please start a Sentry transaction before calling this function.', 'test_decorator.my_example_function'), call('[Monitor] health check negative, downsampling with a factor of %d', 10)].

Stack Trace
tests/tracing/test_decorator.py:45: in test_trace_decorator_no_trx
    fake_debug.assert_called_once_with(
/usr/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'mock' to be called once. Called 2 times.
E   Calls: [call('Cannot create a child span for %s. Please start a Sentry transaction before calling this function.', 'test_decorator.my_example_function'),
E    call('[Monitor] health check negative, downsampling with a factor of %d', 10)].

✅ Patch coverage is 100.00%. Project has 2334 uncovered lines.
✅ Project coverage is 90.15%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.91%    90.15%    +0.24%
==========================================
  Files          193       186        -7
  Lines        24828     23692     -1136
  Branches      8930      8526      -404
==========================================
+ Hits         22322     21358      -964
- Misses        2506      2334      -172
- Partials      1416      1362       -54

Generated by Codecov Action

@sentrivana
sentrivana merged commit d6827b0 into major/3.0 Aug 5, 2026
128 of 130 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-launchdarkly-init branch August 5, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants