Repository navigation
test(tus): bump up shutdown timeouts - #2185
Merged
Merged
Conversation
Give test_tus_rate_limit and the restart phase of test_tus_shutdown a 10s SDK shutdown timeout instead of the default 2s. Windows ARM64 runners can hit the deadline while pruning ten 100 MiB cached attachments, leaving an envelope and its .dmp on disk. The shutdown test's resumed 100 MiB PATCH upload can also be cancelled by the deadline, leaving expected HTTP requests unfulfilled. Keep the first shutdown-test run on the default timeout to cover interruption and persistence. These jobs failed on attempt 1 and passed on attempt 2: test_tus_rate_limit, Windows arm64 (October 7 and 9, 2026): https://github.com/getsentry/sentry-native/actions/runs/37620539204/job/112789385904 https://github.com/getsentry/sentry-native/actions/runs/37938992887/job/113848220716 test_tus_shutdown, Windows latest (August 13 and September 4, 2026): https://github.com/getsentry/sentry-native/actions/runs/31714840874/job/94496808740 https://github.com/getsentry/sentry-native/actions/runs/33868048236/job/101007293905
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
- Coverage 75.52% 75.52% -0.01%
==========================================
Files 103 103
Lines 28089 28089
Branches 5150 5150
==========================================
- Hits 21214 21213 -1
+ Misses 5528 5524 -4
- Partials 1347 1352 +5 🚀 New features to boost your workflow:
|
JoshuaMoelans
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigate random CI failures by bumping up the default 2s shutdown timeout to 10s for selected TUS tests dealing with large files and uploads.
Cache pruning in
test_tus_rate_limitRestart phase of
test_tus_shutdown